TWC Today Forums

TWC Today => Questions, Comments, Suggestions => Topic started by: TWCToday on March 13, 2010, 04:36:13 AM

Title: Weather Data
Post by: TWCToday on March 13, 2010, 04:36:13 AM
To receive weather conditions based on your location next to your posts, just enter your location. To do this go to Profile -> Modify Profile -> Forum Profile

The software will read City, State. ie Norfolk, VA or Norfolk, Virginia
Title: Re: Weather Data
Post by: BOLT96 on March 13, 2010, 08:36:17 AM
Sounds like a very cool idea!  :biggrin:
Title: Re: Weather Data
Post by: Tyler on March 13, 2010, 11:45:00 AM
I like this idea! Just like over at Eastern US Wx Forums. Question...do you have to have such detailed obs, or can you just include basic info? Just wondering.
Title: Re: Weather Data
Post by: Jonathan on March 13, 2010, 12:04:14 PM
Sounds great! (:
Title: Re: Weather Data
Post by: Anistorm on March 13, 2010, 12:24:45 PM
Interesting.... I'm in.  :biggrin:
Title: Re: Weather Data
Post by: Jonathan on March 13, 2010, 12:31:08 PM
I like this idea! Just like over at Eastern US Wx Forums. Question...do you have to have such detailed obs, or can you just include basic info? Just wondering.

He already answered that in the first post. :) He wants to include an icon, the current conditions, temperature, and wind.
Title: Re: Weather Data
Post by: WeatherWitness on March 13, 2010, 01:24:19 PM
What a cool idea! :thrilled: Please do this! :biggrin:
Title: Re: Weather Data
Post by: tuez13 on March 14, 2010, 01:18:25 AM
Very awesome!!!!!!  It's like bringing each of our locations to YOU!

Would we be able to choose which icon set we'd like to display? ;)
Title: Re: Weather Data
Post by: phw115wvwx on March 14, 2010, 03:46:24 AM
The whole idea is interesting to me, but too much weather data can really clutter everything.  I think mentioning the location with a weather icon, current conditions, and a temperature is sufficient as that's basically the focus of the CC screen on a LF.
Title: Re: Weather Data
Post by: gt1racerlHDl on March 14, 2010, 11:04:09 AM
Love the idea! can't wait to see this under my username :D
Title: Re: Weather Data
Post by: Mike M on March 15, 2010, 06:21:12 AM
I like the idea, although do you think you could use weather.com's reports? There are some areas where airports are very sparse, including where I live.
Title: Re: Weather Data
Post by: TWCToday on March 18, 2010, 01:57:38 AM
I like the idea, although do you think you could use weather.com's reports? There are some areas where airports are very sparse, including where I live.
Going to use weather.com's API :yes:
Title: Re: Weather Data
Post by: Localonthe8s on March 18, 2010, 03:56:08 PM
me likey :D
Title: Re: Weather Data
Post by: Jonathan on March 18, 2010, 07:50:23 PM
I like the idea, although do you think you could use weather.com's reports? There are some areas where airports are very sparse, including where I live.
Going to use weather.com's API :yes:

I think we should use Weather Underground...for obvious reasons...:\ The personal weather stations are *much* more reliable than TruPoint, plus the issue about airports. There are many stations on WU...I just think it would be a better choice for accuracy.
Title: Re: Weather Data
Post by: toxictwister00 on March 18, 2010, 09:20:09 PM
I agree with Jonathan, I rather we use WU obs than TWC's obs.
Title: Re: Weather Data
Post by: tuez13 on March 18, 2010, 09:21:53 PM
Correct me if I'm wrong, but doesn't WU offer more weather information readily available versus TWC.com?  Whenever I have been on WU, it seems as though I have seen more info there versus TWC.com.
Title: Re: Weather Data
Post by: Tyler on March 18, 2010, 09:58:54 PM
I'm against using data from WU, because weather.com's data is much more reliable, and they provide conditions for areas in which WU doesn't (WU only gets data from personal weather stations and NWS ob sites).
Title: Re: Weather Data
Post by: curtjr4 on March 18, 2010, 10:18:54 PM
I have to agree with Tyler on that.
Title: Re: Weather Data
Post by: tuez13 on March 19, 2010, 01:27:12 AM
That's not true; our observation is taken from the airport at WU which is still one of the official observation points, with the option to view close personal stations.  Just an FYI.  Doesn't matter which source we use, just pointing it out :)
Title: Re: Weather Data
Post by: phw115wvwx on March 19, 2010, 01:41:57 AM
If your area is near an airport or a reliable personal weather station, then Weather Underground works well.  However, some personal weather stations can be fluky as I've seen weird data at times, and many of them can go offline and be unavailable.  Areas far away from any official stations would need the weather.com data.  It may not be quite as accurate as an airport observation, but it'll be far more reliable.  So, I think weather.com is fine to use for this forum just to cover everyone here.
Title: Re: Weather Data
Post by: TWCToday on March 19, 2010, 01:57:15 AM
Well the main push to use weather.com is the fact the API is a bit easier to use.
Title: Re: Weather Data
Post by: Tyler on March 19, 2010, 02:14:58 AM
Martin, it's late,  and it's a school night. Go to bed. :P
Title: Re: Weather Data
Post by: Anistorm on March 19, 2010, 02:16:30 AM
I personally like weather underground. weather.com is also okay.

Martin, it's late,  and it's a school night. Go to bed. :P

^^^^ I agree.  :bleh:
Title: Re: Weather Data
Post by: TWCToday on March 19, 2010, 02:17:11 AM
If you all INSIST :P
Title: Re: Weather Data
Post by: tuez13 on March 19, 2010, 04:29:14 PM
lol YEAH!!!  Go to bed, jeeze!!  (obviously it's too late not for that to really work, so save it for 1a tonight)
Title: Re: Weather Data
Post by: TWCToday on April 24, 2010, 07:21:43 PM
Testing it out today. More changes to it on the way ;)
Title: Re: Weather Data
Post by: beanboy89 on April 24, 2010, 08:41:52 PM
Testing it out today. More changes to it on the way ;)
How can I set it up? I don't see an option for it in the profile preferences.
Title: Re: Weather Data
Post by: TWCToday on April 24, 2010, 08:56:04 PM
Testing it out today. More changes to it on the way ;)
How can I set it up? I don't see an option for it in the profile preferences.
Its based on your location. There were a lot of NA conditions a few min ago because I had to purchase an extended database. Billy just set your location. Right now you just have Pennsylvania in yours.

Same applies to everyone. Just enter your location. To do this go to Profile -> Modify Profile -> Forum Profile
Title: Re: Weather Data
Post by: beanboy89 on April 24, 2010, 09:00:32 PM
Testing it out today. More changes to it on the way ;)
How can I set it up? I don't see an option for it in the profile preferences.
Its based on your location. There were a lot of NA conditions a few min ago because I had to purchase an extended database. Billy just set your location. Right now you just have Pennsylvania in yours.

Same applies to everyone. Just enter your location. To do this go to Profile -> Modify Profile -> Forum Profile
Very cool, Martin. Thanks.  :biggrin:
Title: Re: Weather Data
Post by: jtmal0723 on April 24, 2010, 09:11:46 PM
The mod is adding an extra " " garbled characters at the top of the forum page making it look awkward... only on pages with the "mod" on it.
Title: Re: Weather Data
Post by: TWCToday on April 24, 2010, 09:27:20 PM
Strange. Its only on Firefox. IE, Opera, Chrome are all fine. Looking into it

Edit: Should be fixed
Title: Re: Weather Data
Post by: WeatherWitness on April 24, 2010, 10:39:14 PM
Awesome that this mod works!!! :biggrin: Cool idea! :D
Title: Re: Weather Data
Post by: TWCToday on April 24, 2010, 10:47:40 PM
I will be working on changing the icons too
Title: Re: Weather Data
Post by: tuez13 on April 24, 2010, 10:57:53 PM
GREAT WORK getting it up!  I was confused at first until I reread the thread about where it grabbed your location...then it was all good.  Very awesome!  Thanks, Martin!
Title: Re: Weather Data
Post by: jtmal0723 on April 24, 2010, 10:58:04 PM
Use the icons from the Beatuiful Weather/Widget app for Android >_>
Title: Re: Weather Data
Post by: wxntrafficfan on April 24, 2010, 11:00:07 PM
Too bad I can't have the option of actually setting it to an airport's observations (which are what can actually be called observations). For now, I have my location set to "n/a".
Title: Re: Weather Data
Post by: TWCToday on April 24, 2010, 11:19:47 PM
Too bad I can't have the option of actually setting it to an airport's observations (which are what can actually be called observations). For now, I have my location set to "n/a".
Something looks better than nothing but have it your way
Title: Re: Weather Data
Post by: beanboy89 on April 24, 2010, 11:28:56 PM
Too bad I can't have the option of actually setting it to an airport's observations (which are what can actually be called observations). For now, I have my location set to "n/a".
What are you talking about? As far as I can tell, the observations ARE coming from an airport.
Title: Re: Weather Data
Post by: TWCToday on April 24, 2010, 11:32:28 PM
Too bad I can't have the option of actually setting it to an airport's observations (which are what can actually be called observations). For now, I have my location set to "n/a".

What are you talking about? As far as I can tell, the observations ARE coming from an airport.

They are. Go to http://www.twctodayforums.com/weather/hw3.php (http://www.twctodayforums.com/weather/hw3.php) and enter your location. It says the airport code for your area
Title: Re: Weather Data
Post by: phw115wvwx on April 24, 2010, 11:43:40 PM
Too bad I can't have the option of actually setting it to an airport's observations (which are what can actually be called observations). For now, I have my location set to "n/a".
Aaron, these aren't HiRAD observations.  It gives you the nearest airport observation based on your location every hour.  Look up that site Martin gave above.  I already tested it out for a bunch of locations, and it works well. :yes:

Nice job on this mod so far, Martin! :thumbsup:
Title: Re: Weather Data
Post by: TWCToday on April 25, 2010, 01:07:05 AM
The way the 2007+ icons are shaped make the icons very tiny. I am considering using XL icons if nobody objects.
Title: Re: Weather Data
Post by: wxntrafficfan on April 25, 2010, 09:35:54 AM
Too bad I can't have the option of actually setting it to an airport's observations (which are what can actually be called observations). For now, I have my location set to "n/a".
What are you talking about? As far as I can tell, the observations ARE coming from an airport.

Not according to this post...
I like the idea, although do you think you could use weather.com's reports? There are some areas where airports are very sparse, including where I live.
Going to use weather.com's API :yes:
Title: Re: Weather Data
Post by: phw115wvwx on April 25, 2010, 10:30:01 AM
Martin didn't use weather.com's API.  He's using the PHP feature from HAMWeather, which is a site that displays everything from the NWS.  As a result, all the obs are from airports.
Title: Re: Weather Data
Post by: Mike M on April 25, 2010, 10:37:35 AM
Do you think you can switch to weather.com instead? Airports are pretty sparse, especially in the midwest. There aren't any here in Marlton.
Title: Re: Weather Data
Post by: Tyler on April 25, 2010, 12:42:37 PM
There's no way to do that with HAMWeather.
Title: Re: Weather Data
Post by: TWCToday on April 25, 2010, 12:44:29 PM
Do you think you can switch to weather.com instead? Airports are pretty sparse, especially in the midwest. There aren't any here in Marlton.
Sadly not at this time. This was the easiest solution at the moment but I can look into changes.

The icons are messed up at the moment. My fault on that one. I will be working and tweaking them
Title: Re: Weather Data
Post by: Pop Light Brown on April 29, 2010, 12:35:58 AM
I am lost like a mug. :dunno:

EDIT: Never mind...I see it. However, that report under my name is from McComb, MS.
Title: Re: Weather Data
Post by: phw115wvwx on April 29, 2010, 02:07:17 AM
I am lost like a mug. :dunno:

EDIT: Never mind...I see it. However, that report under my name is from McComb, MS.
It's going by the nearest airport observation based on the location you enter into your profile at this time.
Title: Re: Weather Data
Post by: TWCToday on May 16, 2010, 01:37:00 AM
New icons now installed :) Also lets you know if you have a weather alert
(http://img37.imageshack.us/img37/6397/testnp.png)
Title: Re: Weather Data
Post by: phw115wvwx on May 16, 2010, 01:47:17 AM
Nice job, Martin!  I assume the weather alert means that any kind of advisory, watch, or warning is currently in effect.
Title: Re: Weather Data
Post by: wxntrafficfan on May 16, 2010, 01:50:34 AM
That's odd, it's telling me I have a weather alert, when there are no bulletins for hundreds of miles from here.
Title: Re: Weather Data
Post by: phw115wvwx on May 16, 2010, 01:56:36 AM
That's odd, it's telling me I have a weather alert, when there are no bulletins for hundreds of miles from here.
Check your NWS page.  Your county is currently under a flood advisory.
Title: Re: Weather Data
Post by: wxntrafficfan on May 16, 2010, 02:01:51 AM
That's odd, it's telling me I have a weather alert, when there are no bulletins for hundreds of miles from here.
Check your NWS page.  Your county is currently under a flood advisory.
Oops, forgot they issued one on the Sycamore Creek. That site always has a Flood Advisory every time I turn around.
Title: Re: Weather Data
Post by: Eric on May 16, 2010, 11:55:06 AM
New icons now installed :) Also lets you know if you have a weather alert
([url]http://img37.imageshack.us/img37/6397/testnp.png[/url])


Bravo!  Now it looks more like The Weather Channel!   :clap:
Title: Re: Weather Data
Post by: WeatherWitness on May 16, 2010, 02:00:40 PM
The icons are nice, but is it possible to use ones without white edges? :dunno: I know I have some saved on my computer that are very clear, and I'm pretty sure they were made by one of our members (but now I can't remember who :wall:). I know the edges aren't that visible, but I think the clearer ones would look nice, too. :yes:
Title: Re: Weather Data
Post by: Eric on May 16, 2010, 02:17:43 PM
The icons are nice, but is it possible to use ones without white edges? :dunno:

Which white edges are you talking about?  I don't see any.
Title: Re: Weather Data
Post by: TWCToday on May 16, 2010, 03:34:43 PM
The icons are nice, but is it possible to use ones without white edges? :dunno: I know I have some saved on my computer that are very clear, and I'm pretty sure they were made by one of our members (but now I can't remember who :wall:). I know the edges aren't that visible, but I think the clearer ones would look nice, too. :yes:
If you can provide them to me and email them to me (@gmail.com) I can take a look at them
Title: Re: Weather Data
Post by: Tyler on May 16, 2010, 03:52:50 PM
Yeah, I have the whole set without the white edges if you're interested. I can email them when I get home later tonight.
Title: Re: Weather Data
Post by: Zach on May 16, 2010, 03:59:32 PM
Martin, I thought the icons now were the ones I sent you a while back. :unsure: They don't have white edges when I view them on my computer. :no:
Title: Re: Weather Data
Post by: TWCToday on May 16, 2010, 05:33:12 PM
Martin, I thought the icons now were the ones I sent you a while back. :unsure: They don't have white edges when I view them on my computer. :no:
Well they do here. The icons you sent me were from the SDK and thats what I used.

Its more than likely a byproduct of the badge creating process.
Title: Re: Weather Data
Post by: Eric on May 16, 2010, 06:18:12 PM
Either I'm blind or my computer's playing games with me, because I still can't see any white edges around the icons!  :dunno:
Title: Re: Weather Data
Post by: WeatherWitness on May 16, 2010, 07:05:27 PM
Either I'm blind or my computer's playing games with me, because I still can't see any white edges around the icons!  :dunno:

As I said before, they're not that noticeable. :no: I'm just being very picky (sorry), and since we have clearer icons, why not use them. :) Martin, if you don't get the icons from Tyler, I'll be happy to e-mail them to you! :D Thanks for the consideration of this request. :biggrin:
Title: Re: Weather Data
Post by: phw115wvwx on May 16, 2010, 10:27:27 PM
Either I'm blind or my computer's playing games with me, because I still can't see any white edges around the icons!  :dunno:
I can assure you that they are there.  It's just a white edge running all the way around the icons, which does show up against the light blue background.  It's not too big a deal as Andy said, but if Tyler and Martin want to make them better, that's perfectly fine with me. B)
Title: Re: Weather Data
Post by: TWCToday on May 16, 2010, 11:55:53 PM
I can barely see it. Since the icons on my computer have no such white border I am lead to believe its part of the badge creation process. In which there isn't much we can do. Ill try one other icon from these clearer ones when someone sends them to me and try it out
Title: Re: Weather Data
Post by: wxntrafficfan on May 17, 2010, 04:40:32 PM
Nice idea Martin, I like how you put a white background behind the weather mods. I was seeing the white halo, but not always.
Title: Re: Weather Data
Post by: Zach on May 17, 2010, 06:35:07 PM
I can barely see it. Since the icons on my computer have no such white border I am lead to believe its part of the badge creation process. In which there isn't much we can do. Ill try one other icon from these clearer ones when someone sends them to me and try it out
I went ahead and sent them to your Gmail. :yes:

Btw, I'm on my desktop now and I can't even see the white edges, it's just on my laptops in which I see them. :wacko:
Title: Re: Weather Data
Post by: WeatherWitness on May 17, 2010, 11:22:18 PM
Nice idea Martin, I like how you put a white background behind the weather mods. I was seeing the white halo, but not always.


Not to be rude, but what the heck are you and Martin talking about? :wacko:

Martin, I apologize for being busy this weekend and today; I haven't been able to give you clearer icons yet.

I just think there is a difference between this: (http://img295.imageshack.us/img295/1826/mcfuzzy.png) and this: (http://img22.imageshack.us/img22/3593/mcclear.png)
Title: Re: Weather Data
Post by: TWCToday on May 18, 2010, 12:09:30 AM
Nice idea Martin, I like how you put a white background behind the weather mods. I was seeing the white halo, but not always.

Not to be rude, but what the heck are you and Martin talking about? :wacko:
I don't know what he is talking about. What I am talking about is the fact the images I have DO NOT have the white border on them. The white border shows up when the weather badge (the thing under your username) is created. To prove this point, here is your image you provided above with the old one. (I temporarily changed the partly cloudy icon because nobody had mostly cloudy as a CC anymore). As you can see, yes your icon is clearer but the white frame remains.
Title: Re: Weather Data
Post by: Tyler on May 18, 2010, 12:37:12 AM
I can easily do that. What size do you need them?
Title: Re: Weather Data
Post by: TWCToday on May 18, 2010, 01:41:03 AM
I can easily do that. What size do you need them?
If you could get them to 52x52 that would be great!
Title: Re: Weather Data
Post by: Eric on May 18, 2010, 03:05:17 AM
Nice idea Martin, I like how you put a white background behind the weather mods. I was seeing the white halo, but not always.

Not to be rude, but what the heck are you and Martin talking about? :wacko:
I don't know what he is talking about. What I am talking about is the fact the images I have DO NOT have the white border on them. The white border shows up when the weather badge (the thing under your username) is created. To prove this point, here is your image you provided above with the old one. (I temporarily changed the partly cloudy icon because nobody had mostly cloudy as a CC anymore). As you can see, yes your icon is clearer but the white frame remains.

I prefer the top version - the moon is more visible.
Title: Re: Weather Data
Post by: wxntrafficfan on May 18, 2010, 12:28:54 PM
Not to be rude myself, but you guys kind of were being so. I did see a white box around the mods yesterday... but it may have been since I was using my dad's laptop, which is from the early days of laptops, and has IE 5.
Title: Re: Weather Data
Post by: TWCToday on May 18, 2010, 08:30:45 PM
Not to be rude myself, but you guys kind of were being so. I did see a white box around the mods yesterday... but it may have been since I was using my dad's laptop, which is from the early days of laptops, and has IE 5.
Did you read anything that was posted above  :rolleyes:
Title: Re: Weather Data
Post by: Jonathan on May 21, 2010, 08:00:27 PM
The icons in the weather data are forced to be in the GIF format...which don't support alpha blending. (That means that some pixels may be more transparent than others. Alpha blending is found in PNG.) In GIF, you can have white borders or jagged, ugly edges. There are examples attached below. Which one looks better?

Martin can't help this, unless he wants to put up with a huge mess of coding. The weather data system that converts everything into the images you see here downconverts any icons into GIF format, as with the text (it's not anti-aliased). It really can't be helped easily, unless we have someone here who is good with coding with images.
Title: Re: Weather Data
Post by: jtmal0723 on May 21, 2010, 08:12:55 PM
Here's something you can play with and test, if you feel... These are the icons from the Beautiful Widgets app for Android... I'm unsure how they would convert in to gif, but why not, lol.... Some are actual forecast icons, some are current condition icons...

Chance of Snow:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_chancesnow.png)

Chance of Snow (night):
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_chancesnow_n.png)

Chance of Storm:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_chancestorm.png)

Chance of Storm (night)
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_chancestorm_n.png)

Cloudy:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_cloudy.png)

Cloudy/Rain:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_cloudyrain.png)

Cloudy/Rain (night):
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_cloudyrain_n.png)

Flurries:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_flurries.png)

Fog:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_fog.png)

Haze:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_haze.png)

Icy/Rain:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_icyrain.png)

Light Rain:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_lightrain.png)

Mostly Cloudy:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_mostlycloudy.png)

Mostly Cloudy (night):
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_mostlycloudy_n.png)

Mostly Sunny:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_mostlysunny.png)

Mostly Sunny (night):
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_mostlysunny_n.png)

Rain:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_rain.png)

Snow:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_snow.png)

Storm:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_storm.png)

Sunny:
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_sunny.png)

Sunny (night):
(https://twctodayforums.com/.sekret/Beautiful_Widgets_v2.81/res/drawable-mdpi/weather_sunny_n.png)
Title: Re: Weather Data
Post by: WeatherWitness on May 21, 2010, 09:24:22 PM
These icons are beautiful!!! :biggrin: Unfortunately, however, I converted one to a GIF, and the quality is wretched. :cry: However, do you happen to have the full set of these icons and mind if I use them, Jesse? :unsure:

Since it looks like we are stuck with what we have, I think what we have now will do...I'm fine with it. :)
Title: Re: Weather Data
Post by: jtmal0723 on May 22, 2010, 12:12:05 AM
These icons are beautiful!!! :biggrin: Unfortunately, however, I converted one to a GIF, and the quality is wretched. :cry: However, do you happen to have the full set of these icons and mind if I use them, Jesse? :unsure:

Since it looks like we are stuck with what we have, I think what we have now will do...I'm fine with it. :)
that is the full set afaik, it was extracted from the apk file itself. I am unsure if there are more icons in the set. Yes you may use them.
Title: Re: Weather Data
Post by: texasstooge on May 22, 2010, 12:53:43 PM
I definitely love the icon change. Thanks Martin!!